Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14615] Add implementation of DomainParticipant::find_topic #2716

Merged
merged 33 commits into from
Jun 21, 2022
Merged

[14615] Add implementation of DomainParticipant::find_topic #2716

merged 33 commits into from
Jun 21, 2022

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 2, 2022 •
edited
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #14615. Added basic TopicProxy class.
0998819 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Topic holds TopicProxy, which is created by DomainPartic…
322e302 
…ipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicProxy constructs and owns Topic.
c976bc0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicImpl is not TopicDescriptionImpl and does not hold …
637807f 
…user topic pointer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicImpl constructor is public.
8ad653a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicImpl header cleanup.
9eb8c55 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Added TopicProxyFactory class with basic interface.
b0149c7 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicProxyFactory empty implementation.
d6dde52 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicProxyFactory holds TopicImpl by composition.
f264f66 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicProxyFactory holds list of created proxy objects.
8f4654a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Implementation of TopicProxyFactory::can_be_deleted.
520220f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Implementation of TopicProxyFactory::delete_topic.
b414a93 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Implementation of TopicProxyFactory::create_topic.
652ce67 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Adding enable_topic and get_topic to TopicProxyFactory.
3655203 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. DomainParticipantImpl uses TopicProxyFactory.
dc5cb1c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Move find_topic to DomainParticipantImpl.
5381372 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Notify a condition when a topic is created.
49ea325 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Implementation of DomainParticipantImpl::find_topic.
c019872 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Fixed segfault on test.
3132215 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Fixed return value on delete_topic.
7932671 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Avoid using input topic on delete_topic.
41c0783 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Always use input listener.
47f16a1 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Internal set_listener methods return void.
b72309c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicProxyFactory::for_each.
157d836 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicImpl holds pointer to TopicProxyFactory.
afc7f3c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. DomainParticipantImpl::set_topic_listener.
44a3425 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. TopicImpl::set_listener with mask.
5785f76 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Topic::set_listener propagates mask.
9262a42 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Correctly handling infinite timeout.
fe4dee4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Jun 2, 2022
@MiguelCompany
Refs #14615. Uncrustify.
0e9e5c8 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title [14615] Implementation of DomainParticipant::find_topic [14615] Add implementation of DomainParticipant::find_topic Jun 2, 2022
@MiguelCompany
Refs #14615. Fixed non-c++11 code.
eadf8af 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@EduPonz EduPonz self-requested a review June 15, 2022 13:29
@MiguelCompany
Refs #14615. Improve doxydoc.
8af4751 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #14615. Assertion on dynamic_cast result.
9ab899a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/find_topic/implementation branch from 49ee4eb to 9ab899a Compare June 21, 2022 08:15
@EduPonz EduPonz merged commit 4e44ea9 into feature/find_topic/main Jun 21, 2022
@EduPonz EduPonz deleted the feature/find_topic/implementation branch June 21, 2022 12:31
MiguelCompany added a commit that referenced this pull request Jun 22, 2022
@MiguelCompany
Add implementation of DomainParticipant::find_topic (#2769)
39b5148 
* Add tests for DomainParticipant::find_topic (#2698)

* Refs #14615. Basic test infrastructure.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-01.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Mock type support..

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-02.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Utility method to compare two topics.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-03.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Utility method to create test topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-04.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-05.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Remove from ParticipantTests.UnsupportedMethods.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Suggestions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Add implementation of DomainParticipant::find_topic (#2716)

* Refs #14615. Added basic TopicProxy class.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Topic holds TopicProxy, which is created by DomainParticipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxy constructs and owns Topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl is not TopicDescriptionImpl and does not hold user topic pointer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl constructor is public.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl header cleanup.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Added TopicProxyFactory class with basic interface.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory holds TopicImpl by composition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory holds list of created proxy objects.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::can_be_deleted.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::create_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Adding enable_topic and get_topic to TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. DomainParticipantImpl uses TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Move find_topic to DomainParticipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Notify a condition when a topic is created.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of DomainParticipantImpl::find_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed segfault on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed return value on delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Avoid using input topic on delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Always use input listener.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Internal set_listener methods return void.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory::for_each.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl holds pointer to TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. DomainParticipantImpl::set_topic_listener.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl::set_listener with mask.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Topic::set_listener propagates mask.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Correctly handling infinite timeout.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed non-c++11 code.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Improve doxydoc.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Assertion on dynamic_cast result.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz